search

XRPLF / xrpl-py

A Python library to interact with the XRP Ledger (XRPL) blockchain
ISC License
151 stars 86 forks source link

Upgrade the minimum supported version to Python 3.9 #769

Closed ckeshava closed 3 weeks ago

ckeshava commented 3 weeks ago

High Level Overview of Change

This fixes https://github.com/XRPLF/xrpl-py/issues/768.

Context of Change

Type of Change

Did you update CHANGELOG.md?

Test Plan

The existing unit and integration tests must suffice.

coderabbitai[bot] commented 3 weeks ago

[!IMPORTANT]

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
🪧 Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit , please review it.` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](http://discord.gg/coderabbit) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
socket-security[bot] commented 3 weeks ago

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
pypi/alabaster@0.7.16 None 0 72 kB bitprophet
pypi/anyio@4.6.2.post1 environment, eval, filesystem, network, shell, unsafe +4 849 kB Thomas.Grainger, Zac-HD, agronholm, ...2 more
pypi/docutils@0.21.2 environment, eval, filesystem, network, shell, unsafe 0 8.18 MB felixwiemann, goodger, grubert, ...1 more
pypi/sphinx@7.4.7 environment, eval, filesystem, network, shell, unsafe +198 719 MB AA-Turner, tk0miya
pypi/sphinxcontrib-applehelp@2.0.0 environment, filesystem, shell +22 262 kB tk0miya
pypi/sphinxcontrib-devhelp@1.0.6 environment Transitive: filesystem +6 690 kB tk0miya
pypi/sphinxcontrib-htmlhelp@2.0.6 environment, filesystem Transitive: eval +10 13.5 MB tk0miya
pypi/sphinxcontrib-qthelp@2.0.0 environment Transitive: filesystem +22 173 kB tk0miya
pypi/sphinxcontrib-serializinghtml@2.0.0 filesystem, unsafe +22 141 kB tk0miya

🚮 Removed packages: pypi/alabaster@0.7.13, pypi/anyio@4.5.2, pypi/coverage@7.6.1, pypi/docutils@0.20.1, pypi/sphinx@7.1.2, pypi/sphinxcontrib-applehelp@1.0.4, pypi/sphinxcontrib-devhelp@1.0.2, pypi/sphinxcontrib-htmlhelp@2.0.1, pypi/sphinxcontrib-qthelp@1.0.3, pypi/sphinxcontrib-serializinghtml@1.1.5

View full report↗︎

mvadari commented 3 weeks ago

I don't think the minimum version should be updated unless we need to. Why remove backwards compatibility when we don't have to, especially since the version only just EOLed a month ago?

ckeshava commented 3 weeks ago

@mvadari Since the EOL is already completed, Python 3.8 will not receive any bug-fixes. Am I understanding that correctly?

If it will not be actively maintained, will the software be reliable?

Besides, dependencies like black have stopped supporting Python 3.8. Check the third-bullet-point here: https://github.com/psf/black/releases/tag/24.10.0

mvadari commented 3 weeks ago

@mvadari Since the EOL is already completed, Python 3.8 will not receive any bug-fixes. Am I understanding that correctly?

If it will not be actively maintained, will the software be reliable?

Plenty of people use old versions of code. Some people still use Python 2.x. We shouldn't force them to upgrade unless we need to (e.g. if an actual dependency upgrades).

Besides, dependencies like black have stopped supporting Python 3.8. Check the third-bullet-point here: https://github.com/psf/black/releases/tag/24.10.0

Black is only relevant to contributors, not users. We can run the linting on just >= 3.9.

ckeshava commented 3 weeks ago

@mvadari Alright, if that's the case, I can close this PR