search

XRPLF / xrpl.js

A JavaScript/TypeScript API for interacting with the XRP Ledger in Node.js and the browser
https://xrpl.org/
1.2k stars 510 forks source link

Decide how to handle the AccountDelete transaction fee #1117

Closed intelliot closed 2 years ago

intelliot commented 4 years ago

The AccountDelete Transaction has a transaction cost of 5,000,000 drops (before load scaling), per https://xrpl.org/transaction-cost.html#special-transaction-costs

This bumps into the 2,000,000 drop fee limit imposed on all transactions by default, so AccountDelete can't be used unless maxFeeXRP is set to '5' or higher. https://xrpl.org/rippleapi-reference.html

Is this acceptable, or do we want to make a special case for AccountDelete?

ximinez commented 4 years ago

My feeling is that deleting an account is unusual enough, both in expected frequency and in having the much higher fee, that I don't see a problem requiring callers to set maxFeeXRP for that case. If they choose to set maxFeeXRP for all transactions, they're only going over the default by 2.5x so it's not an enormous mistake.

tuloski commented 4 years ago

I agree with @ximinez .

intelliot commented 4 years ago

👍 We'll just need to make sure this requirement is well-documented so folks aren't confused when their AccountDelete tx fails due to setting the fee too low.

mvadari commented 2 years ago

Resolved by #1626