search

XRPLF / xrpl.js

A JavaScript/TypeScript API for interacting with the XRP Ledger in Node.js and the browser
https://xrpl.org/
1.21k stars 512 forks source link

Upgrade to lerna 7 #2342

Open justinr1234 opened 1 year ago

justinr1234 commented 1 year ago

Had issues publishing with lerna6 so we downgraded - https://github.com/XRPLF/xrpl.js/pull/2341

JST5000 commented 1 year ago

To add a bit more context, when trying to publish xrpl.js with lerna v6, @mvadari and I encountered two different issues consistently which prevented us from releasing.

On my machine, running npx lerna publish from-package --dist-tag beta --yes from step 10 in the release process would consistently result in an error saying minimatch is not a function. This is a dependency within npm itself. Trying the steps in this StackOverflow post didn't work: https://stackoverflow.com/questions/76049247/typeerror-minimatch-is-not-a-function-error-when-running-new-expo-project

This happened even when I cloned a fresh version of the repository to my computer and when I changed my npm version from 8 to 9.

@mvadari experienced a different problem consistently where her code said there was a missing dependency run 1.4.0 during the pre-publish step, then the publish step would hang infinitely on the npm pack step.

Reverting lerna from v6 to v4 fixed the issue for @mvadari letting us publish.

So, this issue would need to figure out why that issue is happening so we can actually do releases with Lerna v6.