Open drunkirishcoder opened 11 months ago
We should seriously discuss about this.
And, it is not enough to simply make Wallet.sign() an async function, as we sometimes want to sent transactions on the remote wallet side (not xrpl.js side) when signing with Remote Wallet within client.signAndSubmit()
.
And it is also necessary to match the Client's connection network with the RemoteWallet's connection network. We need to consider whether we simply pass the NetworkID or use a different identifier.
This Standard proposal would greatly help this Issue. https://github.com/XRPLF/XRPL-Standards/discussions/206
I would like to implement a wallet that signs remotely and be able to integrate with xrpl. something like
I can extend my remote wallet from the xrpl wallet,
export class MyRemoteWallet extends xrpl.Wallet
, but the problem is thesign
function is not async, therefore I can't make a remote call from it. though becausesubmitAndWait
is async, it should be able to support an async sign function.essentially if this block of code can be changed to
everything would work. this change would make extending xrpl with remote wallets much easier.