XRPLF / xrpl.js

A JavaScript/TypeScript API for interacting with the XRP Ledger in Node.js and the browser
https://xrpl.org/
1.19k stars 507 forks source link

Provide support for Ownership Proofs #2648

Closed 0x4Graham closed 4 months ago

0x4Graham commented 4 months ago

Hi 👋

Can you please consider providing support for ownership proofs, such as a simple API `signMessage([Your message]). This is a common standard in all other networks and Ripple should consider supporting such functionality.

pdp2121 commented 4 months ago

Hi @0x4Graham , thanks for raising the issue. Just to be clear, is it the ability to sign arbitrary amount of data and then verify the signer? If so, I will create a ticket and put it into our backlog

mvadari commented 4 months ago

ripple-keypairs already supports this via the verify method.

0x4Graham commented 4 months ago

is your team the owner of the ledger ripple app?

https://github.com/LedgerHQ/ledger-live/blob/6f65590ef1521aedfcbf31a74b740b8db3c73cc4/libs/ledgerjs/packages/hw-app-xrp/src/Xrp.ts

Right now, there is no support for that.

mvadari commented 4 months ago

You'll have to raise that issue with Ledger.