additional amm flags are introduced - Githubissues

XRPLF / xrpl.js

A JavaScript/TypeScript API for interacting with the XRP Ledger in Node.js and the browser

https://xrpl.org/

1.19k stars 507 forks source link

additional amm flags are introduced #2667

Closed ckeshava closed 3 months ago

ckeshava commented 3 months ago

High Level Overview of Change

Fix https://github.com/XRPLF/xrpl.js/issues/2666

This PR introduces additional flags used in the AMM-related transactions. I'm using these lines of code as the source of truth: https://github.com/XRPLF/rippled/blob/69143d71f8973e33b701d7becc19da2ad6a68b68/src/ripple/protocol/TxFlags.h#L166

Context of Change

This change brings forth certain AMMFlags into the xrpl-js client library.

Type of Change

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Refactor (non-breaking change that only restructures code)
[ ] Tests (You added tests for code that already exists, or your new feature included in this PR)
[ ] Documentation Updates
[ ] Release

Did you update HISTORY.md?

[ ] Yes
[ ] No, this change does not impact library users Do I need to update HISTORY file? this change implements what was promised in the AMM-transaction documentation.

Test Plan

I'm not familiar with the AMM-transactions to write unit tests for all these flags. Please let me know if you have any ideas.

mvadari commented 3 months ago

This should probably be released before AMM goes live tomorrow