feat: Upgrade to Node 18 and remove cross-fetch

XRPLF / xrpl.js

A JavaScript/TypeScript API for interacting with the XRP Ledger in Node.js and the browser

https://xrpl.org/

1.21k stars 512 forks source link

Closed justinr1234 closed 2 months ago

justinr1234 commented 6 months ago

Fixes #2676

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[X] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Refactor (non-breaking change that only restructures code)
[ ] Tests (You added tests for code that already exists, or your new feature included in this PR)
[ ] Documentation Updates
[ ] Release

Automated tests

socket-security[bot] commented 6 months ago

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package	New capabilities	Transitives	Size	Publisher
npm/@noble/curves@1.4.0	None	`0`	1.39 MB	paulmillr
npm/@scure/base@1.1.6	None	`0`	80.4 kB	paulmillr
npm/@types/lodash@4.17.1	None	`0`	862 kB	types
npm/@types/node@18.19.39	None	`0`	1.97 MB	types

🚮 Removed packages: npm/@noble/curves@1.4.2, npm/@scure/base@1.1.7, npm/@types/lodash@4.17.6, npm/@types/node@16.18.46, npm/cross-fetch@4.0.0

mvadari commented 5 months ago

This should be done in a major version bump.

ckeshava commented 2 months ago

FYI: Node 18 has LTS support only until April 2025. We will need to perform a similar obviation of Node 18 at that time

mvadari commented 2 months ago

FYI: Node 18 has LTS support only until April 2025. We will need to perform a similar obviation of Node 18 at that time

In the past, for the most part we keep support for the version until we need to remove it or until it's super old.