fix: reduce faucet to 1000 - Githubissues

XRPLF / xrpl.js

A JavaScript/TypeScript API for interacting with the XRP Ledger in Node.js and the browser

https://xrpl.org/

1.19k stars 507 forks source link

fix: reduce faucet to 1000 #2682

Closed justinr1234 closed 1 month ago

justinr1234 commented 2 months ago

High Level Overview of Change

The faucet has been reduced to 1000 XRP per request - https://xrpl.org/blog/2024/testnet-reset

Context of Change

Reduce from 2000 to 1000 in faucet test

Type of Change

[X] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Refactor (non-breaking change that only restructures code)
[ ] Tests (You added tests for code that already exists, or your new feature included in this PR)
[ ] Documentation Updates
[ ] Release

Did you update HISTORY.md?

[ ] Yes
[X] No, this change does not impact library users

Test Plan

Tests pass in CI

justinr1234 commented 2 months ago

@mvadari is there a way to make these tests not brittle on testnet reset?

justinr1234 commented 1 month ago

Merged in another ticket