Open elmurci opened 5 months ago
Hey there, did you also check https://github.com/XRPLF/xrpl.js/pull/2214
Hey there, did you also check #2214
@elmurci
I have created a PR for client.submit()
and client.submitAndWait()
to support definitions as well.
If it looks good, please consider including it in this PR.
@elmurci
I have created a PR for
client.submit()
andclient.submitAndWait()
to support definitions as well. If it looks good, please consider including it in this PR.
done, thanks @tequdev
@elmurci looks like something broke TS
@elmurci Here is a commit that fixes the current lint error. Please use it if necessary.
https://github.com/tequdev/xrpl.js/commit/4f93aa800c7c0f1152538cacb42b0ba943c568d2
@coderabbitai full review
[!WARNING]
Rate limit exceeded
@justinr1234 has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 29 minutes and 55 seconds before requesting another review.
How to resolve this issue?
After the wait time has elapsed, a review can be triggered using the `@coderabbitai review` command as a PR comment. Alternatively, push new commits to this PR. We recommend that you space out your commits to avoid hitting the rate limit.How do rate limits work?
CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our [FAQ](https://coderabbit.ai/docs/faq) for further information.Commits
Files that changed from the base of the PR and between f3960c3cccc26f7e595fc4365a68fdd52db03be3 and 2c60a1eccf86df388baceb5c76a74d67becb6f72.
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
High Level Overview of Change
In previous versions, custom definition support was added to the
ripple-binary-codec
methods but not the proxy ones in thexrpl
package.This PR adds support for Custom Definitions to the following
xrpl
methods:utils.encode
utils.decode
utils.encodeForSigning
Wallet.sign
client.submit()
(@tequdev)client.submitAndWait
(@tequdev)Context of Change
When using custom definitions, you had to directly use the
encode
,decode
, andencodeForSigning
methods fromripple-binary-codec
. Those features can now be used via the proxy methods in thexrpl
package.Custom definition support has also been added to the
Wallet.sign
method which wasn't the case before.Type of Change
Did you update HISTORY.md?
Test Plan
Added 3 unit tests for:
Wallet.sign
(single signature)Wallet.sign
(multisignature)Wallet.sign
(unknown transaction type)