XRPLF / xrpl.js

A JavaScript/TypeScript API for interacting with the XRP Ledger in Node.js and the browser
https://xrpl.org/
1.19k stars 507 forks source link

introduce DeliverMax alias in Payment transactions #2684

Closed ckeshava closed 1 week ago

ckeshava commented 2 months ago

High Level Overview of Change

This is a sister PR of the following xrpl-py work: https://github.com/XRPLF/xrpl-py/pull/684

Context of Change

Type of Change

Did you update HISTORY.md?

Test Plan

Unit tests have been added, but I am unable to add integration tests. I couldn't find any examples of specifying a JSON representation (not Payment, AccountSet or any SubmittableTransaction type) as an input to the submitTransaction function. This is necessary because DeliverMax is an alias at the RPC level, it is not recognised at the protocol level. Let me know if I'm missing something.

khancode commented 1 week ago

Closing this since the other solution was merged in - https://github.com/XRPLF/xrpl.js/pull/2689