Add nfts_by_issuer data type - Githubissues

XRPLF / xrpl.js

A JavaScript/TypeScript API for interacting with the XRP Ledger in Node.js and the browser

https://xrpl.org/

1.19k stars 507 forks source link

Add nfts_by_issuer data type #2694

Closed Kassaking7 closed 3 weeks ago

Kassaking7 commented 1 month ago

High Level Overview of Change

Title

Context of Change

Following https://xrpl.org/docs/references/http-websocket-apis/public-api-methods/clio-methods/nfts_by_issuer/ & https://ripplelabs.atlassian.net/jira/software/projects/DEFI/boards/760?assignee=712020%3Aff4deb34-7fc1-428e-a2ee-354e1ddba309&selectedIssue=DEFI-127

Type of Change

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Refactor (non-breaking change that only restructures code)
[ ] Tests (You added tests for code that already exists, or your new feature included in this PR)
[ ] Documentation Updates
[ ] Release

Did you update HISTORY.md?

[x] Yes
[ ] No, this change does not impact library users

Test Plan

pdp2121 commented 1 month ago

Could you add a test file for this new method? Cheers :)

Kassaking7 commented 1 month ago

Could you add a test file for this new method? Cheers :)

I'm not sure if this could be tested. I think the lib currently doesn't support integration test for Clio?

shawnxie999 commented 1 month ago

@pdp2121 the library doesn't support test for clio, which is the reason why nft_info and nft_history don't have test cases.