search

XRPLF / xrpl.js

A JavaScript/TypeScript API for interacting with the XRP Ledger in Node.js and the browser
https://xrpl.org/
1.19k stars 507 forks source link

Replace use of `convertStringToHex`/`convertHexToString` with `stringToHex`/`hexToString` #2698

Open mvadari opened 1 month ago

mvadari commented 1 month ago

convertStringToHex and convertHexToString are deprecated functions: https://github.com/XRPLF/xrpl.js/blob/main/packages/xrpl/src/utils/stringConversion.ts

These functions are really only still used in tests and snippets, so this is a pretty low priority issue. Just leaving it here as a reminder.

Princeyadav05 commented 1 month ago

@mvadari can I give this one a try? I'm sure I would be able to tackle with your guidance.

mvadari commented 1 month ago

@mvadari can I give this one a try? I'm sure I would be able to tackle with your guidance.

Feel free, but I won't be able to provide any guidance.

Princeyadav05 commented 1 month ago

@mvadari can I give this one a try? I'm sure I would be able to tackle with your guidance.

Feel free, but I won't be able to provide any guidance.

Sure, will give it a try.