search

XRPLF / xrpl.js

A JavaScript/TypeScript API for interacting with the XRP Ledger in Node.js and the browser
https://xrpl.org/
1.2k stars 510 forks source link

Missing interface for path_find #729

Closed codedot closed 2 years ago

codedot commented 8 years ago

RippleAPI is currently missing interface for the path_find request. Currently, the only pathfinder interface in RippleAPI seems to be the getPaths() method which is based on a simpler version of pathfinder, namely ripple_path_find.

--- Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/36669701-missing-interface-for-path_find?utm_campaign=plugin&utm_content=tracker%2F323756&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F323756&utm_medium=issues&utm_source=github).
intelliot commented 6 years ago

@codedot Sorry for the delay in replying to you. What's your use case for path_find?

In the latest version of ripple-lib, you can use the request method to call any of the rippled APIs, including path_find.

codedot commented 6 years ago

My use case for path_find used to be a market-taking bot. However, reimplementing that old piece of software using the new low-level method request seems to require too much work.

intelliot commented 6 years ago

Is there an old path_find method that we can bring back?

I’ve only been working on ripple-lib for about a year so I’m wondering if you’re referring to something that was in an old version.

codedot commented 6 years ago

In ripple-lib@0.10.0, there was a method called pathFind which provided a convenient enough interface for the path_find request.

intelliot commented 6 years ago

Ah, that was 3+ years ago. Yes, I think this is a great idea.

Anyone out there interested in contributing a PR? (@yxxyun?)

mvadari commented 3 years ago

Resolved with #1503

mvadari commented 2 years ago

Resolved by #1576 as well