XRPLF / xrpl.js

A JavaScript/TypeScript API for interacting with the XRP Ledger in Node.js and the browser
https://xrpl.org/
1.2k stars 511 forks source link

Unexpected behavior due to variable versions of dependencies #736

Closed codedot closed 6 years ago

codedot commented 7 years ago

The latest version 4.8.0 of the ajv package prints the following message to standard output

$ref: all keywords used in schema at path "#". It will change in the next major version, see issue #260. Use option { extendRefs: true } to keep current behaviour

when .preparePayment() method is called in RippleAPI.

Requesting freezing all dependencies of ripple-lib at exact versions tested.

One workaround is to specify

        "dependencies": {
                "ajv": "4.0.5",
                "ripple-lib": "0.17.3"
        }

in package.json of a package that requires ripple-lib.

--- Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/38450442-unexpected-behavior-due-to-variable-versions-of-dependencies?utm_campaign=plugin&utm_content=tracker%2F323756&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F323756&utm_medium=issues&utm_source=github).
ihomp commented 7 years ago

same for me,

https://github.com/epoberezkin/ajv/issues/303 https://github.com/epoberezkin/ajv/issues/260

ihomp commented 6 years ago

can be closed, not an issue in 0.17.7 just update :)

intelliot commented 6 years ago

Thank you!