XRPLF / xrpl.js

A JavaScript/TypeScript API for interacting with the XRP Ledger in Node.js and the browser
https://xrpl.org/
1.2k stars 510 forks source link

RippleAPI's getTransactions slows down to a crawl #748

Closed njmurarka closed 3 years ago

njmurarka commented 7 years ago

I have noticed the following:

Imagine W is an issuing address. X has a trustline to USD.W. X is sending USD.W to Y, where Y has a trustline to EUR.Z and where some Market Maker converts USD.X to EUR.Z.

Now imagine hundreds or even thousands of such transactions going through per hour.

Try "getTransactions" on W, especially on a WSS (web sockets secure) endpoint. Unless you provide a very recent TX hash ALFA or a very recent "last ledger" BRAVO, this request could take forever and even fail with a timeout. Notice that technically NO transactions were actually "sent" to W.

Somehow, "traffic" involving W seems to slow down lookups on W.

--- Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/43382593-rippleapi-s-gettransactions-slows-down-to-a-crawl?utm_campaign=plugin&utm_content=tracker%2F323756&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F323756&utm_medium=issues&utm_source=github).
intelliot commented 6 years ago

@njmurarka Thanks for reporting this issue. Could you provide a code-level example (or proof of concept) that demonstrates the problem?

mvadari commented 3 years ago

Closing this because getTransactions no longer exists (#1550). If you still have this issue with other methods, please reopen this issue.