search

XRPLF / xrpl.js

A JavaScript/TypeScript API for interacting with the XRP Ledger in Node.js and the browser
https://xrpl.org/
1.2k stars 511 forks source link

Feature request: support signing with ECDSA secp256k1 and Ed25519 private keys #797

Closed matejr closed 4 years ago

matejr commented 7 years ago

Sign method should support signing with ECDSA secp256k1 and Ed25519 private keys (and not just with Ripple secret keys).

The format of these private keys needs to be documented.

--- Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/49290801-feature-request-support-signing-with-ecdsa-secp256k1-and-ed25519-private-keys?utm_campaign=plugin&utm_content=tracker%2F323756&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F323756&utm_medium=issues&utm_source=github).
intelliot commented 7 years ago

Thanks for submitting this issue. Could you elaborate on what the use case for this feature would be?

matejr commented 7 years ago

Easier generation of vanity addresses (account ids) with split-key mining, easier integration with hardware devices which store ECDSA private keys (it is not possible to use exported private key in any RippleAPI-based wallet), etc.

intelliot commented 4 years ago

This is now supported by specifying a keypair to the sign method. https://xrpl.org/rippleapi-reference.html#sign

With regards to the documentation of the format of the private keys, there's room for improvement. I'll open a new issue for that.