search

XRPLF / xrpl4j

A 100% Java implementation to interact with the XRP Ledger.
ISC License
86 stars 48 forks source link

Validate UnsignedByteArray's .equals method #173

Closed sappenin closed 2 years ago

sappenin commented 2 years ago

If two UnsignedByteArray references are not equal, we should check the list references, and if those aren't equal, then do a deep compare to check for equality (the current implementation leaves this comparison up to the implementation, which might cause unintended consequences).

sappenin commented 2 years ago

I created https://github.com/XRPLF/xrpl4j/issues/248 which is slightly related to this issue.