search

XRPLF / xrpl4j

A 100% Java implementation to interact with the XRP Ledger.
ISC License
86 stars 48 forks source link

Add transaction metadata to TransactionResult #18

Closed nkramer44 closed 3 years ago

nkramer44 commented 3 years ago

We should add the metadata field to TransactionResult in case anyone needs it

nkramer44 commented 3 years ago

This should be prioritized. Without it, there is no way to know if a transaction was successful, since transactions can sometimes make it into a validated ledger without being applied. See https://livenet.xrpl.org/transactions/EFF72FE2E58BDEAE0D9E1D5C86C8A784AF9844C6AB1E59C8F4BB7C62E2B910D4 as an example

nkramer44 commented 3 years ago

Mostly fixed by https://github.com/XRPLF/xrpl4j/pull/53