search

XRPLF / xrpl4j

A 100% Java implementation to interact with the XRP Ledger.
ISC License
80 stars 45 forks source link

Revert logback-classic to 1.3.X to work with JDK 8 #509

Closed nkramer44 closed 7 months ago

nkramer44 commented 7 months ago

I noticed after dependabot bumped logback-classic from 1.3.x to 1.4.x that logging stopped working and I saw this warning: Failed to load class org.slf4j.impl.StaticLoggerBinder. According to https://www.slf4j.org/codes.html#StaticLoggerBinder, logback-classic 1.4.x targets slf4j v2.x.x, so I tried to bump slf4j to v2.0.9 and logback-classic to 1.4.x. However, logback-classic 1.4.x supports JDK 11 and up, not JDK 8, which we try to support in xrpl4j. Therefore, I downgraded logback-classic to the latest 1.3.x and bumped slf4j to v2.0.7 based on https://logback.qos.ch/download.html

codecov[bot] commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (24bf996) 91.61% compared to head (aab7856) 91.65%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #509 +/- ## ============================================ + Coverage 91.61% 91.65% +0.04% Complexity 1774 1774 ============================================ Files 365 365 Lines 4948 4948 Branches 408 408 ============================================ + Hits 4533 4535 +2 + Misses 282 280 -2 Partials 133 133 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.