XRPLF / xrpl4j

A 100% Java implementation to interact with the XRP Ledger.
ISC License
80 stars 45 forks source link

LedgerResult Deserialization: Invalid but parseable EscrowFinish fulfillment #513

Open nkramer44 opened 6 months ago

nkramer44 commented 6 months ago

Certain fulfillments and conditions that show up in validated (but not executed) EscrowFinish transactions are able to be parsed by CryptoConditionReader, but are actually malformed (for example if a Fulfillment has a well formed first 32 bytes, but has extra bytes attached afterward). This causes an exception to be thrown when deserializing the EscrowFinish from JSON.

Offending transactions:

sappenin commented 6 months ago

What should the fix logic be here?