search

XRPLF / xrpl4j

A 100% Java implementation to interact with the XRP Ledger.
ISC License
80 stars 45 forks source link

Add support for unknown TransactionType #521

Open rsteimen opened 5 months ago

rsteimen commented 5 months ago

Add an UnknownTransaction object that can take the place of a transaction that xrpl4j doesn't yet support. For example, loading transactions from Xahau should not blow-up (but currently they would).

sappenin commented 4 months ago

Hi @rsteimen - thanks for filing this issue, and for your PR. Overall, I like the problem you're solving for, and need to review your PR to consider things more deeply (e.g., I think if we want to support this kind of change, we may want to align how we handle unknown LedgerObjects with the pattern/APIs you proposed).

Overall, I don't have a timeline for you here -- but wanted to "ack" your submission. Thanks for proposing it!