XRPLF / xrpl4j

A 100% Java implementation to interact with the XRP Ledger.
ISC License
80 stars 45 forks source link

`AmmBid` expects BidMax to be of type `IssuedCurrencyAmount` but it can be a string #529

Closed exp0nge closed 3 weeks ago

exp0nge commented 2 months ago

The current JSON deserializer expects BidMax to be of IssuedCurrencyAmount, however, as observed on mainnet, this is not always the case:

https://xrpscan.com/ledger/BAA4AF508E9A9CB7685D9E61B82486681E52E9B920904B0650499497F050D8FA Tx https://xrpscan.com/tx/6A8BC948E1309219EA8E14905D0EA9BB94E24429DE5B15CDE8916CDBCE42034B provides a string value of "10"

nkramer44 commented 1 month ago

Those fields were typed as IssuedCurrencyAmounts because the docs say that bids are made using LP tokens, though it looks as though the docs are incorrect. I'll work on a fix for this shortly.