search

XRPLF / xrpl4j

A 100% Java implementation to interact with the XRP Ledger.
ISC License
80 stars 45 forks source link

Fix 529: Make all AMM transaction IssuedCurrencyAmount fields CurrencyAmounts #534

Closed nkramer44 closed 3 weeks ago

nkramer44 commented 1 month ago

Fixes #529 by retyping all IssuedCurrencyAmounts in AMM related transactions to CurrencyAmounts.

This does not constitute a breaking change, because these transactions were marked @Beta.

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 91.65%. Comparing base (2a68c4a) to head (a2ceb2c).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #534 +/- ## ========================================= Coverage 91.65% 91.65% Complexity 1774 1774 ========================================= Files 365 365 Lines 4948 4948 Branches 408 408 ========================================= Hits 4535 4535 Misses 280 280 Partials 133 133 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

exp0nge commented 1 month ago

Any idea when this PR will be fixed & a release cut?

nkramer44 commented 3 weeks ago

Any idea when this PR will be fixed & a release cut?

@exp0nge We're planning on merging this and releasing a fix version some time this week or early next (this week is Apex)

abhaar-gemini commented 1 week ago

@nkramer44 Any updates on releasing a patched version with this fix?