XRTK / com.xrtk.core

The Official Mixed Reality Framework for Unity
https://xrtk.io
MIT License
309 stars 34 forks source link

Scriptable Render Pipeline Support #407

Open FejZa opened 5 years ago

FejZa commented 5 years ago

XRTK - Mixed Reality Toolkit Feature Request

Is your feature request related to a problem? Please describe

Unity has introduced scriptable render pipelines as a replacement to the legacy render pipeline some time ago. The URP - Universal Render Pipeline - (formerly LWRP) as well as the HDRP are out of preview by now and the modern way to get started with Unity projects. It is to be expected most people utilizing XRTK will be using URP or HDRP in their projects, that's why the standard assets need to be updated to support those. Currently all standard assets will render the pink error shader if used with render pipelines.

How would you classify your suggestion

Describe the solution you'd like

As the HDRP documentation notes:

NOTE: Projects made using HDRP are not compatible with the Lightweight Render Pipeline. You must decide which render pipeline your project will use before starting development as HDRP features are not cross-compatible between HDRP and Lightweight.

unfortunately there is no way to have an automated workflow for converting projects in between pipelines. Anyway an automatic conversion would most likely not produce tuned and 100% optimized assets for each pipeline, that's why I am suggesting the following changes:

StephenHodgson commented 4 years ago

We talked about this a bit yesterday but wanted to add the conversation remarks here.

We discussed dropping the MRTK standard shader in favor of making this change

StephenHodgson commented 3 years ago

This should likely also fix https://github.com/XRTK/XRTK-Core/issues/686

StephenHodgson commented 2 years ago

I actually don't think this is a breaking change. I've noticed how some asset packages will just overwrite the local assets in the assets folder. We should likely do something similar when we copy/clone the assets from the sdk