search

XRTK / com.xrtk.core

The Official Mixed Reality Framework for Unity
https://xrtk.io
MIT License
309 stars 34 forks source link

Wrong actions detected if ActionsProfile names change #425

Closed milos12345 closed 4 years ago

milos12345 commented 4 years ago

XRTK - Mixed Reality Toolkit Bug Report

Wrong actions detected if names changed - names will be new but IDs will be from the old action.

To Reproduce

I have removed several actions, added a few and renamed some.

Expected behavior

There should be a way to auto regenerate IDs so the correct actions are called without the need to delete ActionsProfile and create a new one

Actual behavior

Actions are modified in ActionsProfile, and OnInputDown will get wrong actions. The InputEventData will get new names but same IDs so comparison of received event data and the action expected will return wrong result. If I realize that one of the action in the middle is unnecessary, it seems that deleting it will mess IDs of other actions on the list. In addition, if new profile has less number of actions, the triggering the last action on the list will result in ~index out of bounds logged into console

Your Setup (please complete the following information)

Target Platform (please complete the following information)

StephenHodgson commented 4 years ago

Swapping the input actions from another configuration is not supported yet.

See #379 && #111

When we update the input actions to scriptable objects we should be able to track and detect when an input action had been modified, changed, or a whole new profile has been swapped out.