XRTK / com.xrtk.core

The Official Mixed Reality Framework for Unity
https://xrtk.io
MIT License
309 stars 34 forks source link

Move project level settings to Project Settings Window #532

Open FejZa opened 4 years ago

FejZa commented 4 years ago

XRTK - Mixed Reality Toolkit Change Request

Is your change request related to a problem? Please describe

XRTK currently puts its settings into Unity's Preferences window, which is for editor preferences. XRTK's project level settings should move to the Project Settings window.

How would you classify your suggestion

Describe the solution you'd like

Move XRTK project level settings into Project Settings window instead of Preferences.

Additional context

xrtk_preferences

StephenHodgson commented 4 years ago

These settings are in the correct place.

Project level settings are for project specific things.

I could see the need to move the generated profile and start scene.

@Jarodshow weren't you working on something for this?

FejZa commented 4 years ago

They are most definitely not. XRTK is almost by definition a project level tool. It brings no benefit to the editor in general that is not tied to a project. So I can't see how they are in the right place here.

FejZa commented 4 years ago

For some of the above I guess one can argue they are editor prefernces, yes.

StephenHodgson commented 4 years ago

I just didn't feel like there was enough to warrant two different menu screens.

I think @Jarodshow was working on an update to this window.

jshowacre commented 4 years ago

This is all in the fix/editorprefs branch :)

jshowacre commented 4 years ago

I could see the need to move the generated profile and start scene.

This is in the project settings currently. @FejZa feel free to push(or tell me) any additional settings you see fit