XRTK / com.xrtk.core

The Official Mixed Reality Framework for Unity
https://xrtk.io
MIT License
309 stars 34 forks source link

Installation failed on MacOS #783

Closed ScarlettZ98 closed 3 years ago

ScarlettZ98 commented 3 years ago

XRTK - Mixed Reality Toolkit Bug Report

Describe the bug

After downloading the XRTK via Manual UPM Installation, the package doesn't work with System.IO.FileNotFoundException in the console.

To Reproduce

  1. Download XRTK by manually modifying manifest.json as described in the tutorial.
  2. Unity automatically resolves changes
  3. 571 FileNotFoundException show in the console.
  4. Mixed Reality ToolKit -> Configure only adds a MixedRealityToolKit object in the hierarchy, different from the expected result in the tutorial

Expected behavior

No errors in the console and Mixed Reality ToolKit -> configure should create objects like MixedRealityPlayspace, PlayerBody, etc.

Actual behavior

571 FileNotFoundException show in the console. It seems the script use backslash which is widely used in Windows, but MacOS and Linux use slash.

Screenshots

Screen Shot 2021-02-12 at 8 38 59 AM

Your Setup

StephenHodgson commented 3 years ago

Thanks for reporting this!

I'll be sure to update the package installer with the more appropriate file directory character separators.

StephenHodgson commented 3 years ago

https://github.com/XRTK/XRTK-Core/blob/353f7daf1006069aa1e5c54d588c1240e065697f/XRTK-Core/Packages/com.xrtk.core/Editor/PackageInstaller.cs#L187

Fairly certain it's bc we're missing the .ToForwardSlashes() call on the end of this line

StephenHodgson commented 3 years ago

Related discord thread https://discord.com/channels/597064584980987924/696053083444346890/796429411527294987

StephenHodgson commented 3 years ago

@ScarlettZ98 fix will be in the next release 0.2.7

ScarlettZ98 commented 3 years ago

Thank you so much! I will view the discord post to see if I can fix it temporarily or maybe wait for the next update.

StephenHodgson commented 3 years ago

@ScarlettZ98 there is a 0.2.7.preview.1 out to test :) should be downloadable from the unity package manager