search

XRTK / com.xrtk.core

The Official Mixed Reality Framework for Unity
https://xrtk.io
MIT License
309 stars 34 forks source link

Remove current gLTF utility #800

Closed SimonDarksideJ closed 3 years ago

SimonDarksideJ commented 3 years ago

XRTK - Mixed Reality Toolkit Feature Request

Is your feature request related to a problem? Please describe

Very simple, remove the current gLTF utilities from CORE. They cause more issues than they solve.

Additionally, because it is part of Core, it makes it impossible for an XRTK user to use an alternative.

If we still want to provide our version, then it should be extracted into its own project and updated with the latest capabilities, etc

FejZa commented 3 years ago

"Additionally, because it is part of Core, it makes it impossible for an XRTK user to use an alternative."

I can see this being an issue and removing them makes sense.

You mention other issues. What are those?

StephenHodgson commented 3 years ago

Isn't this a duplicate?

I was gonna try to get around this pretty.

Afaik there's no real bickers besides the build window, but we could just make the gltf asset a prefab reference I suppose.

SimonDarksideJ commented 3 years ago

I think that issue @StephenHodgson should be moved to the separate project should we wish to continue it.

As to issues @FejZa , I have utterly failed to get gLTF models to load now and it complains about gLTF buffers being null. Granted, these are streamed gLTF's, but I already had this working, but now (when I tested again this week) it utterly fails.

But primarily because this is in core, I can't use another solution without drastic measures.

SO I suppose the question is, do we keep it and put it in its own repo or just drop it. My feeling is the former as work has gone in to this, but needs updating to the latest Khronos features and is sorely missing Animation and Streaming