XRTK / com.xrtk.core

The Official Mixed Reality Framework for Unity
https://xrtk.io
MIT License
307 stars 34 forks source link

Data Provider tests for Core Systems and Extension Services updated #868

Closed SimonDarksideJ closed 2 years ago

SimonDarksideJ commented 3 years ago

XRTK - Mixed Reality Toolkit Pull Request

Overview

Updated tests to include validation for data providers registered with their host services, for both "Systems" and "Extension Services"

Changes

Service Tests

Notes

Currently failing as there is an issue with Extension Data Providers being registered with their respective service. Depends on

SimonDarksideJ commented 3 years ago

If there is an issue with the test, please detail it, as the Extension Service and Extension Data Provider have been updated to match what I understand to be the correct pattern, inheriting from the Extension Interfaces. The data provider use has also been updated in the Core and Extension tests to match the real-world implementation we currently have running in our systems (although granted, there is scope for improvement there).

The Core System implementation and it's data providers pass their tests. The same implementation using the Extension interfaces does NOT pass.

Either we need to fix the tests, or change the XRTK extension implementation as it is not currently working as expected.

SimonDarksideJ commented 2 years ago

Will rebuild without dependencies on old PR's