XRTK / com.xrtk.core

The Official Mixed Reality Framework for Unity

https://xrtk.io

MIT License

307 stars 34 forks source link

Remove extension services #871

Closed SimonDarksideJ closed 2 years ago

SimonDarksideJ commented 3 years ago

XRTK - Mixed Reality Toolkit Pull Request

Overview

Removed extension services

Changes

Removed Extension Definitions / Interfaces / Implementatons
Renamed "RegisteredServiceProviders" to "ActiveSystemsDataProviders"
Removed "RegisteredServiceProviders" Profiles and definitions against the "MixedRealityToolkit" service
Removed Extensions Tests
General cleanup and tidy
Updated https://github.com/XRTK/Examples/pull/45

Breaking Changes

Breaks Any implementation using 'Extension' interfaces, should be converted to Systems or Services

SimonDarksideJ commented 3 years ago

Any final comments @StephenHodgson / @FejZa would love to get this cleared up asap.

StephenHodgson commented 3 years ago

I'll give it a once over today

SimonDarksideJ commented 3 years ago

Updated as requested.

However, note. The CUstom Service example will need to be updated accordingly, as it does not currently work. The editor reports a "Constuctor Error" when trying to instantiate a "Custom Service" that has no profile or constructor.

StephenHodgson commented 3 years ago

However, note. The Custom Service example will need to be updated accordingly, as it does not currently work. The editor reports a "Constructor Error" when trying to instantiate a "Custom Service" that has no profile or constructor.

I'll take a look when I get a chance.

SimonDarksideJ commented 3 years ago

Any last comments @StephenHodgson / @FejZa ?

StephenHodgson commented 3 years ago

Sorry haven't had time to check this out

SimonDarksideJ commented 3 years ago

Outstanding issues resolved. Found new issue with the Service Generator for IMixedRealityService's, fixed too.

StephenHodgson commented 3 years ago

Do you guys think we could push this off into 0.4.x release?

FejZa commented 3 years ago

I am fine with that. Let's let @SimonDarksideJ have the last word on this one.