XRTK / com.xrtk.core

The Official Mixed Reality Framework for Unity

https://xrtk.io

MIT License

307 stars 34 forks source link

Remove internal flag on parent profile property #875

Closed FejZa closed 3 years ago

FejZa commented 3 years ago

XRTK - Mixed Reality Toolkit Pull Request

Overview

Removed the internal keyword on the BaseMixedRealityProfile.ParentProfile property setter. This was necessary to be able to set parent profiles in code that lives in another assembly.

FejZa commented 3 years ago

What was the purpose of making it internal? Please see https://github.com/XRTK/Examples/pull/46 for use case.

StephenHodgson commented 3 years ago

Please use use InternalsVisibleTo() assembly attribute instead of making the setter public

FejZa commented 3 years ago

Done