XRTK / com.xrtk.core

The Official Mixed Reality Framework for Unity
https://xrtk.io
MIT License
307 stars 34 forks source link

Enable Camera System to work with XR SDK / 2020.1 and above #897

Closed FejZa closed 2 years ago

FejZa commented 2 years ago

XRTK - Mixed Reality Toolkit Pull Request

Overview

This PR enables the camera system to correctly work with the XR SDK plugin management and sets the camera at the correct height depending on the tracking space configuration.

Changes

Related Submodule Changes

FejZa commented 2 years ago

/azp run

azure-pipelines[bot] commented 2 years ago
Azure Pipelines successfully started running 1 pipeline(s).
StephenHodgson commented 2 years ago

@FejZa still failing

FejZa commented 2 years ago

Wth man. I am starting to believe the pipeline does not pick up the scripting define symbols correctly.

FejZa commented 2 years ago

Project builds perfectly fine locallly.

FejZa commented 2 years ago

Oh yeah. Actually my last commit broke something.

StephenHodgson commented 2 years ago
Packages\com.xrtk.core\Runtime\Providers\CameraSystem\BaseCameraDataProvider.cs(23,61): error CS0535: 'BaseCameraDataProvider' does not implement interface member 'IMixedRealityCameraDataProvider.HeadHeight'
FejZa commented 2 years ago

Ok now I get it. Next commit will fix it.