Updated Camera validation

[SimonDarksideJ]

XRTK - Mixed Reality Toolkit Pull Request

Overview

Updated the camera validation and regeneration as a result of #911

Changes

• Moved Camera validation routines to "OnEnable" in the Camera Provider
• Moved Rig Validation to the OnValidate method, so it is checked at the right time
• Added Rig Validation to the Toolkit Validation methods
• Ensured Toolkit validation ONLY occurs when a profile has been assigned
• Fixed a random bug whereby CameraCache was being called in OnDestroy without first checking there was a camera to destroy (as it created a new camera)
• Updated validation warnings

Tested all scenarios where the scene will be validated:

• New Scene
• New Scene + Configure
• New GO + Toolkit object
• Deleting Toolkit and readding
• Deleting Rig and checking configuration

Fixes:

• https://github.com/XRTK/com.xrtk.core/issues/911

Breaking Changes

None

[SimonDarksideJ]

Making it work altered the tests. Looking for the best way to raise the Profile not set exception

[StephenHodgson]

Overall I am happy with lifting the camera setup out into their own method calls.

Still needs to pass validation.

[SimonDarksideJ]

Ok, changes tested and working as expected now with no adverse effects.

[StephenHodgson]

also resolving comments without an actual resolution doesn't make them "resolved"

[SimonDarksideJ]

Comments addressed

[SimonDarksideJ]

I thought the author of the PR was the one supposed to merge once it had been accepted?? To ensure they hadn't had any further thoughts since posting it for review?