XRTK / com.xrtk.wmr

The Windows Mixed Reality platform components for the XRTK
https://github.com/XRTK/XRTK-Core
MIT License
22 stars 4 forks source link

UWP APPX Build fails for VS 2019 when VS 2017 is not installed #60

Closed StephenHodgson closed 4 years ago

StephenHodgson commented 5 years ago

XRTK - Mixed Reality Toolkit Bug Report

Describe the bug

When a dev only has 2019 installed the build window fails

To Reproduce

  1. Ensure only VS 2019 is installed
  2. Build APPX for UWP
  3. See error

Expected behavior

Devs should be able to build the appx with either 2017 or 2019 depending on what's availible.

Actual behavior

Can only build appx for VS 2017

Your Setup (please complete the following information)

Target Platform (please complete the following information)

Additional context

Might be related to how Unity creates the initial solution and project files. After being prompted to update the solution to a later version the appx build will succeed. We might want to do something similar if only VS 2019 is found or a specific uwp sdk version is selected.

StephenHodgson commented 5 years ago

I also tested this with only installing the VS 2017 build tools only and I still get the following error:

C:\Dev\XRTK.Core\XRTK-Core\Builds\WSAPlayer\Il2CppOutputProject\Il2CppOutputProject.vcxproj(3786,3): error MSB4019: The imported project "C:\Program Files (x86)\Microsoft Visual Studio\2017\BuildTools\Common7\IDE\VC\VCTargets\Microsoft.Cpp.Default.props" was not found. Confirm that the path in the <Import> declaration is correct, and that the file exists on disk.
StephenHodgson commented 5 years ago

More interesting still... I changed from x64 to arm and it built. Maybe it's my installation.

SimonDarksideJ commented 5 years ago

Odd, as my dev laptop I took to MRDevSummit ONLY has VS2019 and Unity 2019 installed and I had no issues.

StephenHodgson commented 5 years ago

Interesting 🤔

FejZa commented 4 years ago

I am pretty sure this is going to go away with moving past 2019.1. 2019.1 still generates a VS solution that needs to be retargeted to build tools v142 to properly build.

StephenHodgson commented 4 years ago

We also need to move the build tools into their platform projects respectively as well.