search

XRichardroidX / SpaceX

MIT License
0 stars 0 forks source link

Kanban board setup for React group project. #96

Open XRichardroidX opened 1 year ago

XRichardroidX commented 1 year ago

https://github.com/XRichardroidX/SpaceX/projects/1

We are 2 developers working on this project.

rustam-tolipov commented 1 year ago

Hello @XRichardroidX,

Good job so far! There are some issues that you still need to work on to go to the next project but you are almost there!

Highlights

Your project is almost complete! No Linters errors

Required Changes ♻️

You need to assign each student to the tasks and make sure they need to be shared equally:

Your image Original image
Screenshot 2023-01-03 at 18 29 21

Optional suggestions

Check the comments under the review.

You can also consider: N/A

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, remember to tag me in your question so I can receive the notification.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

XRichardroidX commented 1 year ago

Thanks for that, I didn't notice the mistake, corrections has been made concerning that, my bad 😄.

Qoosim commented 1 year ago

Status: Required Changes :recycle:

Hi @team,

Great work on making the changes requested by a previous reviewer 👏 You've done well implementing some of the requested changes, but there are still some which aren't addressed yet.

Highlights

assignee

Check the comments under the review.

Optional suggestions

Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, remember to tag me in your question so I can receive the notification.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

XRichardroidX commented 1 year ago

Oh I see, thanks for the heads up 👍 💯.

pinkmoon25 commented 1 year ago

Hi @XRichardroidX & @Progress2002 ,

Your project is complete! There is nothing else to say other than... it's time to merge it :shipit: Congratulations! 🎉

Highlights

Setup kanban :heavy_check_mark: Changes Implemented :heavy_check_mark:

Optional suggestions

Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, remember to tag me in your question so I can receive the notification.

As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.