search

XRobots / openDog

CAD and code for each episode of my open source dog series
GNU General Public License v3.0
825 stars 189 forks source link

Cleaned up degrees to radians calculation #5

Open ghost opened 6 years ago

ghost commented 6 years ago

Created a degrees to radians function and removed a few unnecessary conversions Constants are still in degrees but are converted

XRobots commented 6 years ago

Thanks for that, although I'm not using Git in the 'proper way' for the early videos because if someone watches the video and then looks on Git I want them to see the same code. Most of my normal viewers aren't aware of versioning etc and I want to make the entry point to understanding really easy.

For this reason, any changes in part 2 of the video will be in a separate folder called 'part 2'.

Also this is only one piece of the jigsaw for solving the kinematics, which probably needs to be it's own function so it can be used for each leg. Eventually I'll have a 'working version' that I can merge contributions into on an ongoing basis.

jantje commented 6 years ago

If you do not want to go for releases; wouldn't it be easier to have a "master folder" to work on and copy it to partX folder at release time?

XRobots commented 6 years ago

I'll go for releases in the end, but for now it's more like 'code samples', so there may be completely new bits of test code that relate to each video, or it'll all get scrapped entirely.

adamgreen commented 6 years ago

@harveyaitken I see that you have deleted the repository originally associated with this PR. Should this PR be closed as well? Are you planning to create a new PR for this issue in the future?

XRobots commented 6 years ago

I haven't deleted any repositories - it's still right there.

Yes as I keep saying I'll be writing a completely new version of the code.

adamgreen commented 6 years ago

Sorry, I meant that comment for @harveyaitken since he has deleted his fork of your repository. It was this fork which contained the original changes associated with this PR.

mrbesen commented 4 years ago

For this reason, any changes in part 2 of the video will be in a separate folder called 'part 2'.

I suggest using tags then. Under your videos or in the README.md you can link the tag-page and every user can see all the versions and browse every code of that version.

As example: here is the link for the tag-page of the linux kernel.

If the link of the Commit id, below the version is to subtile for you, you may want to add a markdown link in the description like this:

[browse code](https://github.com/torvalds/linux/commit/d5226fa6dbae0569ee43ecfc08bdcd6770fc4755)

As far as i can tell there are many people wanting to help with their issues and Pullrequests, but the way the code is organized makes it hard and unrewarding. Maybe just put up a open google drive or dropbox folder with the parts in folders as you like to make it easy for unexperienced people and on github make it "the propper" way.