search

XSCE / xsce

xsce code base
Other
32 stars 32 forks source link

Is bangalore.html supposed to be part of upstream master? #816

Closed m-anish closed 7 years ago

m-anish commented 7 years ago

Is xsce/roles/portal/files/alt-home/bangalore.html supposed to be part of upstream master?

tim-moody commented 7 years ago

Yes. My plan has been to throw in everything to serve as samples.

Also many menudefs still need work, especially the ones that are generated from Rachel.

Sent from my Samsung Galaxy smartphone.

-------- Original message -------- From: Anish Mangal notifications@github.com Date: 10/14/16 2:18 AM (GMT-08:00) To: XSCE/xsce xsce@noreply.github.com Subject: [XSCE/xsce] Is bangalore.html supposed to be part of upstream master? (#816)

Is xsce/roles/portal/files/alt-home/bangalore.html supposed to be part of upstream master?

You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHubhttps://github.com/XSCE/xsce/issues/816, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AFami_d_3ZojQPobzCzr1pjEwDXYzyK9ks5qz0jkgaJpZM4KWzX0.

m-anish commented 7 years ago

sample for what? isn't that what the actual homepage is supposed to be.

If it is supposed to be a sample, shouldn't it be in some doc folder, or named as index.html.sample?

tim-moody commented 7 years ago

this was a late addition and there is a lot to be done. more than 80% of the files were generated from rachel and some, like kalite and zims, should be removed as we do thing differently than rachel.

still, I'm not clear as to what the issue is. bangalore.html will only appear if explicitly entered into the browser and no one looks at doc directories. the default index.html is a kitchen sink. if the menu you want is similar to one of the samples that sample is probably a good place to start.

m-anish commented 7 years ago

The issue is that bangalore.html looks like something that should be found in a downstream implementation of XSCE and not in upstream master -- atleast not without proper documentation.

I am using 3 different homepages for three different deployments in India, all of which are far better than the old xs-portal homepage. I dont expect to find them in upstream master, unless they become generic pieces which can be customized by deployments, with proper documentation as to how this is to be done.

Just my two cents.

georgejhunt commented 7 years ago

The whole menuing, portal, approach in 6.2 has shifted, and support for content is shifted to https://github.com/tim-moody/iiab-menu