search

XT-i / aws-lambda-jenkins-plugin

Jenkins plugin for AWS Lambda deployment
MIT License
39 stars 41 forks source link

ProxyConfiguration not honored when run on a Slave #66

Open rostskadat opened 7 years ago

rostskadat commented 7 years ago

Hi,

When running on a slave the http://javadoc.jenkins-ci.org/jenkins/model/Jenkins.html#getInstance() will return null and therefore the com.xti.jenkins.plugin.awslambda.util.LambdaClientConfig#getClientConfiguration() will not honor the proxy setting found on the master.

I would expect the general ProxyConfiguration to be transmitted to the slaves.

cast commented 7 years ago

ProxyConfiguration will be part of LambdaClientConfig and serialized for transfer to slave. On the slave conversion will take place from the ProxyConfiguration to aws ClientConfiguration.

This will be implemented next release.