XUANTIE-RV / openc910

OpenXuantie - OpenC910 Core
Apache License 2.0
1.13k stars 296 forks source link

Some code is not standard-compliant Verilog #2

Closed Icenowy closed 2 years ago

Icenowy commented 2 years ago

https://github.com/T-head-Semi/openc910/blob/main/C910_RTL_FACTORY/gen_rtl/iu/rtl/multiplier_65x65_3_stage.v#L172 Here in the instance, the parameter part should have () at both sides of the number, like the code above.

Without these (), yosys will throw an error for the code, and the Verilog standard requires #() to be a part of parameter_value_assignment .

purplelegant commented 2 years ago

Thank you for your kind reminder! The coding style is fixed in commit 4047f29873a28a653ccbd17e584ba224feee0a55.