Remove unused wires - Githubissues

XUANTIE-RV / openc910

OpenXuantie - OpenC910 Core

Apache License 2.0

1.16k stars 306 forks source link

Remove unused wires #5

Open olofk opened 3 years ago

olofk commented 3 years ago

Signed-off-by: Olof Kindgren olof.kindgren@gmail.com

olofk commented 3 years ago

Hi,

There are more of these. Just sending a first PR to see if this is how you want it fixed

jiijkkk commented 3 years ago

Hi,

There are more of these. Just sending a first PR to see if this is how you want it fixed

Your changement will cause W287b Warning in spyglass lint rule.

olofk commented 3 years ago

Hi,

I don't have access to Spyglass and have no idea what Warning W287b is, so you will need to explain what it means or let me know if you prefer another fix. The root issue is that the code is referring to a wire that isn't declared anywhere and I'm very surprised if Spyglass doesn't warn about that. `default_nettype none would had made it an error

CLAassistant commented 1 year ago

All committers have signed the CLA.