search

XVimProject / XVim

Xcode plugin for Vim keybindings
MIT License
5.16k stars 595 forks source link

How to change the hilight search color? #458

Open johncrane opened 11 years ago

johncrane commented 11 years ago

I am using Xcode's midnight color schema. XVim highlight search shows bright yellow background makes it unreadable. I tryed to use "hi Search ..." in my .xvimrc file, but it does not seem to be working? Is there anyway I can change it?

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

JugglerShu commented 11 years ago

Merge this commit by yourself if you need it now. 4a40c9de896a659b10c8b868a54d98ff4ff91d81 . I may merge it later.

johncrane commented 11 years ago

Thanks. I don't know git, will wait. Currently, I go into the source code and replaced all yellowColor to blueColor. That works for me. Thanks.

On Tue, Sep 17, 2013 at 1:13 PM, JugglerShu notifications@github.comwrote:

Merge this commit by yourself if you need it now. 4a40c9dhttps://github.com/JugglerShu/XVim/commit/4a40c9de896a659b10c8b868a54d98ff4ff91d81. I may merge it later.

— Reply to this email directly or view it on GitHubhttps://github.com/JugglerShu/XVim/issues/458#issuecomment-24605538 .

davidquon commented 10 years ago

This would still be nice to have although I think these code changes in https://github.com/JugglerShu/XVim/commit/4a40c9de896a659b10c8b868a54d98ff4ff91d81 seem outdated now. For now changing yellowColor to blueColor worked for me as well. Thanks.

JugglerShu commented 10 years ago

I added the support for this in 'features/hlcolor#458' branch.

   :highlight Search guibg=#FF0000
   :highlight Search guibg=blue

should work now.

One problem I have now is that when changing color the color does not apply to second text view( assistant editor or other views) Need to call [view setNeedDisplay:YES] for each view when changing the color

arvindraghavan commented 9 years ago

Any plans to merge this branch into master?

gmdfalk commented 9 years ago

+1, this would be a great addition

jasonseney commented 9 years ago

Bump! It's been really hard to make the transition to Xcode without this feature, and the yellow is completely unreadable in any light on dark theme : (

I tried using the hlsearchcolor option, but it doesn't seem to work. Anyone have any tips for a workaround?

keith commented 9 years ago

Looks like this is fixed by https://github.com/XVimProject/XVim/pull/816 currently in the develop branch.