search

XVimProject / XVim

Xcode plugin for Vim keybindings
MIT License
5.16k stars 595 forks source link

[Feature Request] Move XVim menu into Editor menu (or Edit menu). #741

Open yixiang opened 9 years ago

yixiang commented 9 years ago

Inserting XVim as a top-level menu containing only one item doesn't seem ideal. People who have smaller screens would appreciate the menu bar spaced saved, if it is moved into an existing menu such as "Editor", given that Xcode menu bar is already crowded.

--- Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/11898620-feature-request-move-xvim-menu-into-editor-menu-or-edit-menu?utm_campaign=plugin&utm_content=tracker%2F252770&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F252770&utm_medium=issues&utm_source=github).
yixiang commented 9 years ago

Looked in XVim.m and found the following comment

// I have tried to add the item into "Editor" but did not work.
// It looks that the initialization of "Editor" menu is done later...

https://github.com/XVimProject/XVim/blob/c8e4498b26c36538a0ad0bbbd7140a4fe8434a8e/XVim/XVim.m#L69

There should be a solution to this, because the ClangFormat project does insert menu item into "Edit", https://github.com/travisjeffery/ClangFormat-Xcode. Check the code below.

https://github.com/travisjeffery/ClangFormat-Xcode/blob/23297d3fdd3e9c5b7c9619ec1a1d6e81fae1f9c9/ClangFormat/TRVSClangFormat.m#L60

Screenshot:

JugglerShu commented 9 years ago

Well, I'm a little indecisive if I should XVim menu in "edit" not in "editor". Edit menu is for commands to edit test. XVim is just a feature of a editor.

Please let me leave this for a while until I can find the best way...

(If this really helps a lot of people I'll merge this immediately so leave comment here if you feel you need PR)

yixiang commented 9 years ago

Short Version: It's your call. :-)

Long Version: I agree that we need the XVim item in Editor instead of Edit. Edit is just a temporary solution as we figure out how to do Editor. Neither my implementation nor the current implementation (as top level menu item) are perfect. I don't have strong feelings either way. The only minor issue I'm trying to address here is that top level menu item causes developers with smaller screen to run into truncated menu bar. However the top level menu item has the benefit of no developer will miss it as it's so obvious. So I would't feel so bad if you decide not to merge.