search

XVimProject / XVim2

Vim key-bindings for Xcode 9
MIT License
2.31k stars 181 forks source link

fix: wired position cursor jump when Xcode trim whitespace preference is true. #374

Closed r-plus closed 3 years ago

r-plus commented 3 years ago

FIx https://github.com/XVimProject/XVim2/issues/351 FIx https://github.com/XVimProject/XVim2/issues/296

testsed i, I, j and o operations.

pebble8888 commented 3 years ago

I think the problem is not fixed.

How to reproduce: macOS11.2.3 Xcode12.4

スクリーンショット 2021-04-18 6 23 01

4ljo<ESC>i<SPACE><SPACE><SPACE><SPACE><ESC>j in File.swift

スクリーンショット 2021-04-18 6 21 46

And i

スクリーンショット 2021-04-18 6 22 33
r-plus commented 3 years ago

ah, thanks. looks like different behavior on release build and debug build.

r-plus commented 3 years ago

wait, I'm testing #373 branch build. no problem when I tried it again on this branch build.

@pebble8888 Any other condition to show problem?

https://user-images.githubusercontent.com/425216/115133074-5d623380-a040-11eb-9f74-fd5fab0b6c66.mov

r-plus commented 3 years ago

oh, sorry last operation is i i just typed l.

confirmed problem.

r-plus commented 3 years ago

ok, not yet covered i operation. I'll add workaround for that operation.

r-plus commented 3 years ago

fixed for all of the normal evaluator.

pebble8888 commented 3 years ago

Thank you. Great improvement.