XVs32 / kcauto_custom

kcauto_custom, the successor to kcauto, a Kantai Collection (Kancolle) bot / automation tool
https://xvs32.github.io/kcauto_custom/
GNU General Public License v3.0
8 stars 2 forks source link

LBAS resupplying when not needed #80

Closed XVs32 closed 9 months ago

XVs32 commented 9 months ago

What

How

Result

Reference

XVs32 commented 9 months ago

lbas.lbas.manage_lbas() finds all lbas groups which need attention. But lbas.lbas.manage_lbas() is called in combat module after selecting the world. Which means lbas.lbas.manage_lbas() can't switch to the lbas group needs attention, and lbas resupply gets trigger when any of the lbas group needs resupply

XVs32 commented 9 months ago

LBAS resupply reads the plane count and plane max in each team When plane count < plane max, resupply is needed

The problem here is, team 1 of the LBAS does not gets update, while team 2 and 3 are getting the correct plane count (no id shifting is happening, team 2 and team 3 are getting it's own plane count) I suspect this could be somekind of api update issue

XVs32 commented 9 months ago

The api comes from api_get_member/mapinfo when clicked into sortie menu, the plane data is under api_plane_info

The plane count data from api looks good to me, then there should be something wrong around reading the api data into LBAS module

XVs32 commented 9 months ago

Found the reason, finally. LBAS module handle the lbas group going into the next combat only. And the if cause which detect the world of each LBAS team goes wrong.

This bug is fixed in 831adc4ed81cfb50c6404664faf78ee7539551fe