XaF / qolsysgw

Qolsys IQ Panel 2+ gateway to an Home Assistant Alarm Control Panel
MIT License
131 stars 13 forks source link

🐛 Sensor unique IDs deduplication when using modules #113

Closed XaF closed 1 year ago

XaF commented 1 year ago

Some sensors like TakeoverModules and Translators will create extra sensors which share exactly the same sensor ID as the module. This makes sure that every sensor has a unique ID by adding back the zone ID after the sensor ID when the sensor is not the first one which that ID. This will ensure that we can still keep cross-installation sensors for the main sensors, but handle deduplication when using such modules.

Fixes https://github.com/XaF/qolsysgw/issues/108

github-actions[bot] commented 1 year ago

Coverage

Coverage Report
FileStmtsMissCoverMissing
apps/qolsysgw
   gateway.py1683579%95–96, 131–154, 162, 187–188, 207–208, 220–221, 232–233, 242–243, 252–253, 259, 279–280
apps/qolsysgw/mqtt
   exceptions.py170100% 
   listener.py53885%42–44, 68–70, 74–75
   updater.py246797%172, 220, 223, 342, 393, 479, 556
   utils.py50100% 
apps/qolsysgw/qolsys
   actions.py50296%24, 34
   config.py701381%63–64, 66, 70, 75, 90–102, 112, 120, 146
   control.py151795%39, 47, 51, 58, 65, 81, 88
   events.py2322191%64, 69, 100, 104, 130–131, 163, 167, 190, 201, 208, 235, 251, 265, 278–280, 325, 357, 369, 414
   exceptions.py290100% 
   observable.py17382%13, 17–18
   partition.py125894%151, 156–160, 166–170, 173
   sensors.py2352291%60, 67–88, 101, 160, 218, 222, 229, 246, 250
   socket.py951980%36, 43, 52–54, 83–84, 103–105, 109–110, 114–116, 126–127, 133–134
   state.py69790%24, 67–70, 80, 88
   utils.py47491%11, 14, 20–21
TOTAL160915690% 

Tests Skipped Failures Errors Time
120 0 :zzz: 0 :x: 0 :fire: 33.274s :stopwatch: