XaF / qolsysgw

Qolsys IQ Panel 2+ gateway to an Home Assistant Alarm Control Panel
MIT License
131 stars 13 forks source link

New MQTT entity name warning in HA 2023.8.0 #119

Closed nwf closed 1 year ago

nwf commented 1 year ago

Before submitting this form

Description of the bug

I just upgraded HA to 2023.8.0 and it's warning me:

Discovered entities with a name that starts with the device name

This stops working in version 2024.2.0. Please address before upgrading.

Some MQTT entities have an entity name that starts with the device name.  This
is not expected. To avoid a duplicate name the device name prefix is stripped
of the entity name as a work-a-round. Please inform the maintainer of the
software application that supplies the affected entities to fix this issue.

List of affected entities:

  sensor.qolsys_panel_last_error

It's entirely possible that this is something in my configuration rather than a bug per se, but in that case it'd be nice to have a warning that's a little closer to the bad setting?

Expected behavior

Operation without warnings would be nice. :)

DEBUG logs

I don't believe these are relevant, but am happy to provide if I'm wrong.

Additional context

No response

XaF commented 1 year ago

Hello! Thanks for the report!

According to the following threads, this is unrelated to qolsysgw and can be safely ignored:

nwf commented 1 year ago

I don't understand how this can be unrelated to qolsysgw, though I understand that it is safe to ignore right now. Is the sensor.qolsys_panel_last_error name not determined by qolsysgw (that is, is something other than qolsysgw the warning text's "software application that supplies the affected entities")?

wozz commented 1 year ago

@XaF I think you misunderstood those threads. This should be a really simple fix - can we get it merged so that these warnings go away?

nwf commented 1 year ago

Be advised that HA 2023.8.4 has merged a change that removes the Repair notification, but the underlying issue potentially remains.

XaF commented 1 year ago

Finally got to fix the end-to-end tests after this change. @wozz, will run the tests on your patch to get this merged.

XaF commented 1 year ago

Thanks everyone! This is now live in 1.5.0.