XaF / qolsysgw

Qolsys IQ Panel 2+ gateway to an Home Assistant Alarm Control Panel
MIT License
133 stars 13 forks source link

App Daemon update from 0.14 to 0.15 - need change in installation instructions #132

Open amogh79 opened 1 year ago

amogh79 commented 1 year ago

Hi,

Please find attached the screenshot for the update of AppDaemon and the folder structure is changing. Please update the instructions to reflect these changes.

Thanks Amogh AppDaemonUpdate

XaF commented 1 year ago

This only applies to people using the AppDaemon add-on and HASSOS if I'm not mistaken? In which case, this shouldn't require any update of documentation for qolsysgw since its documentation only has a link for the add-on setup, not a full guide!

amogh79 commented 1 year ago

@XaF there are instructions which specify settings in appdaemon.yml and apps.yml. Now these files are moved to addon_configs/xyz_appdaemon

XaF commented 10 months ago

Which part of the documentation are you referring too? The main documentation has been written with docker setup in mind (not HASSOS and addons), but should work for both. I can add a callout if there's a place that specifies paths, but I do not have / use the addons approach so won't be able to write something accurate. I'm open to a pull request to update the documentation though!

Tobbe7612 commented 10 months ago

I have the same thing and using HASSOS. The QolsysGW-app is installed in a directory that AppDaemon does not use after the update. I managed to find that it was possible to point out to appdaemon where the apps are installed by adding "app_dir" configuration in the appdaemon.yaml file. Can this be a solution or? Not an expert in this topics I'm afraid.

XaF commented 10 months ago

The QolsysGW-app is installed in a directory that AppDaemon does not use after the update

That is surprising - could that be a HACS configuration change? I could add a disclaimer for installation location for manual installs, but that won't help for installations done through HACS (which is the preferred way) if it's not doing the right thing when using addons

EDIT: This indeed does not seem configurable in HACS: https://hacs.xyz/docs/categories/appdaemon_apps#appdaemon-apps-download-location

Tobbe7612 commented 10 months ago

Don't you think it might be possible to just point the AppDamon application to the correct path?

XaF commented 10 months ago

You're right! Following your previous comment mentioning app_dir, seems that it would be the approach to take. I was able to find this other comment that suggests the same approach: https://github.com/hassio-addons/addon-appdaemon/issues/302#issuecomment-1816194738

So I guess the simplest solution to this is to add in AppDaemon configuration the app_dir parameter to tell it to behave as it always behaved before that latest update 😅

Will have to think about how to convey that in the documentation since I mostly wrote it with a docker manual setup in mind, while using that or HASSOS was pretty much the same idea.

Tobbe7612 commented 10 months ago

Thanks, I will try this tomorrow

Tobbe7612 commented 10 months ago

It didn't work for me. Got some Mqtt issues. Might be a local problem for me but it seems like there is a complain about bad protocol in the logs

XaF commented 10 months ago

Are you talking about AppDaemon logs ? Home Assistant logs ? MQTT logs ?

Tobbe7612 commented 9 months ago

Solved it! Stupid error from my side. Sorry