XaF / qolsysgw

Qolsys IQ Panel 2+ gateway to an Home Assistant Alarm Control Panel
MIT License
131 stars 13 forks source link

Arming IQ Pro to Night throws an error #160

Open alistairg opened 3 months ago

alistairg commented 3 months ago

Before submitting this form

Description of the bug

When arming to night an error is raised. Checking in the code it looks like support for ARM_NIGHT has been commented out - before I start to attack this, I wanted to see if this was because of some other issue, or simply not yet implemented?

Expected behavior

Home assistant status should reflect the armed_night nature of the panel

DEBUG logs

Traceback (most recent call last): File "/config/apps/qolsysgw/mqtt/listener.py", line 47, in event_callback await self._callback(event)

File "/config/apps/qolsysgw/gateway.py", line 210, in mqtt_event_callback self._state.update(event)

File "/config/apps/qolsysgw/qolsys/state.py", line 56, in update self.notify(change=self.NOTIFY_UPDATE_PARTITIONS,

File "/config/apps/qolsysgw/qolsys/observable.py", line 23, in notify callback(self, **payload)

File "/config/apps/qolsysgw/mqtt/updater.py", line 57, in _state_update self._factory.wrap(partition).configure()

File "/config/apps/qolsysgw/mqtt/updater.py", line 218, in configure self.update_state()

File "/config/apps/qolsysgw/mqtt/updater.py", line 426, in update_state payload=self.ha_status, ^^^^^^^^^^^^^^

File "/config/apps/qolsysgw/mqtt/updater.py", line 342, in ha_status raise ValueError('We need to put a better error here, but ' ValueError: We need to put a better error here, but we found an unsupported status: 'ARM_NIGHT'

Additional context

No response

XaF commented 2 months ago

When arming to night an error is raised. Checking in the code it looks like support for ARM_NIGHT has been commented out - before I start to attack this, I wanted to see if this was because of some other issue, or simply not yet implemented?

The main issue is not being able to identify which panel is what, and so which real set of features are available. To my knowledge, no panel API allows to know the current panel version, and this was built around an IQ Panel 2+ initially. If the IQ Pro supports night, support should be able to be added. Ideally, we'll want to add some configuration option around if arm night should be available or not.