XaF / qolsysgw

Qolsys IQ Panel 2+ gateway to an Home Assistant Alarm Control Panel
MIT License
134 stars 13 forks source link

♻️ [refactor] move mac address resolution to avoid duplication #71

Closed XaF closed 1 year ago

XaF commented 1 year ago

The mac address resolution was done everytime we needed the mac address, instead of doing it once at the beginning while loading the configuration. This fixes that, and refactors the tests since the corresponding utils function changed module.

github-actions[bot] commented 1 year ago

Coverage

Coverage Report
FileStmtsMissCoverMissing
apps/qolsysgw
   gateway.py1583180%95–96, 131–154, 162, 187–188, 216–217, 226–227, 236–237, 243, 263–264
apps/qolsysgw/mqtt
   exceptions.py170100% 
   listener.py53885%42–44, 68–70, 74–75
   updater.py237797%163, 211, 214, 332, 383, 461, 535
   utils.py50100% 
apps/qolsysgw/qolsys
   actions.py50296%24, 34
   config.py701381%62–63, 65, 69, 74, 89–101, 111, 119, 145
   control.py151795%39, 47, 51, 58, 65, 81, 88
   events.py2322191%64, 69, 100, 104, 130–131, 163, 167, 190, 201, 208, 235, 251, 265, 278–280, 325, 357, 369, 414
   exceptions.py290100% 
   observable.py17382%13, 17–18
   partition.py120794%149–153, 159–163, 166
   sensors.py1792288%51–72, 116, 120, 126, 155, 159, 166, 183, 187
   socket.py931980%36, 43, 52–54, 83–84, 103–105, 109–110, 114–116, 126–127, 133–134
   state.py64395%24, 74, 82
   utils.py47491%11, 14, 20–21
TOTAL152214790% 

Tests Skipped Failures Errors Time
114 0 :zzz: 0 :x: 0 :fire: 28.795s :stopwatch:
github-actions[bot] commented 1 year ago

Coverage

Coverage Report
FileStmtsMissCoverMissing
apps/qolsysgw
   gateway.py1583180%95–96, 131–154, 162, 187–188, 216–217, 226–227, 236–237, 243, 263–264
apps/qolsysgw/mqtt
   exceptions.py170100% 
   listener.py53885%42–44, 68–70, 74–75
   updater.py237797%163, 211, 214, 332, 383, 461, 535
   utils.py50100% 
apps/qolsysgw/qolsys
   actions.py50296%24, 34
   config.py701381%62–63, 65, 69, 74, 89–101, 111, 119, 145
   control.py151795%39, 47, 51, 58, 65, 81, 88
   events.py2322191%64, 69, 100, 104, 130–131, 163, 167, 190, 201, 208, 235, 251, 265, 278–280, 325, 357, 369, 414
   exceptions.py290100% 
   observable.py17382%13, 17–18
   partition.py120794%149–153, 159–163, 166
   sensors.py1792288%51–72, 116, 120, 126, 155, 159, 166, 183, 187
   socket.py931980%36, 43, 52–54, 83–84, 103–105, 109–110, 114–116, 126–127, 133–134
   state.py64395%24, 74, 82
   utils.py47491%11, 14, 20–21
TOTAL152214790% 

Tests Skipped Failures Errors Time
114 0 :zzz: 0 :x: 0 :fire: 30.743s :stopwatch: