Add support for `translator` sensor type

efaden commented 1 year ago

Before submitting this form

[X] I have checked that this sensor type was not suggested for addition before; I know that it could be in open or closed issues, and if there was another issue mentioning this sensor type I could simply comment in it instead
[X] I have updated the <sensor type> mention in the title of the issue, but left the issue title as it was otherwise
[X] I understand that if I want to suggest the addition of more than a single sensor type, I need to file that form for each separate type

Sensor type

translator

Home Assistant device class

Tamper

Does the panel send sensor status updates?

[X] Yes, I can see the Open/Close messages (I have been able to capture ZONE_ACTIVE messages)
[] No, it seems to only tell us the sensor exists, but never update its state

Sensor data from an `INFO` message

2023-02-21 08:59:35.018384 WARNING qolsys_panel: sensor of unknown type: {'id': '9441A8', 'type': 'Translator', 'name': 'Translator', 'group': 'translator', 'status': 'Closed', 'state': '0', 'zone_id': 13, 'zone_physical_type': 14, 'zone_alarm_type': 0, 'zone_type': 20, 'partition_id': 0}

2023-02-21 08:59:35.015882 DEBUG qolsys_panel: Notifying <qolsys.state.QolsysState object at 0x7f369d30da50> observers with: {'change': 'update_error', 'prev_value': UnknownQolsysSensorException("Sensor type 'TakeoverModule' unsupported for sensor {'id': '460-2603', 'type': 'TakeoverModule', 'name': 'Hardwire Translator', 'group': 'takeovermodule', 'status': 'Closed', 'state': '0', 'zone_id': 4, 'zone_physical_type': 13, 'zone_alarm_type': 0, 'zone_type': 18, 'partition_id': 0}"), 'new_value': UnknownQolsysSensorException("Sensor type 'Translator' unsupported for sensor {'id': '9441A8', 'type': 'Translator', 'name': 'Translator', 'group': 'translator', 'status': 'Closed', 'state': '0', 'zone_id': 13, 'zone_physical_type': 14, 'zone_alarm_type': 0, 'zone_type': 20, 'partition_id': 0}")}

Sensor data from a `ZONE_EVENT`'s `ZONE_UPDATE` message

2023-02-21 08:59:35.052527 DEBUG qolsys_panel: call_service: mqtt/publish, {'namespace': 'mqtt', 'retain': True, 'topic': 'homeassistant/sensor/qolsys_panel_last_error/attributes', 'payload': '{"type": "UnknownQolsysSensorException", "desc": "Sensor type \'Translator\' unsupported for sensor {\'id\': \'9441A8\', \'type\': \'Translator\', \'name\': \'Translator\', \'group\': \'translator\', \'status\': \'Closed\', \'state\': \'0\', \'zone_id\': 13, \'zone_physical_type\': 14, \'zone_alarm_type\': 0, \'zone_type\': 20, \'partition_id\': 0}"}'}

2023-02-21 08:59:35.052226 DEBUG qolsys_panel: call_service: mqtt/publish, {'namespace': 'mqtt', 'retain': True, 'topic': 'homeassistant/sensor/qolsys_panel_last_error/attributes', 'payload': '{"type": "UnknownQolsysSensorException", "desc": "Sensor type \'TakeoverModule\' unsupported for sensor {\'id\': \'460-2603\', \'type\': \'TakeoverModule\', \'name\': \'Hardwire Translator\', \'group\': \'takeovermodule\', \'status\': \'Closed\', \'state\': \'0\', \'zone_id\': 4, \'zone_physical_type\': 13, \'zone_alarm_type\': 0, \'zone_type\': 18, \'partition_id\': 0}"}'}

Sensor data from a `ZONE_EVENT`'s `ZONE_ACTIVE` message

Can't seem to find

Additional context

There are two devices for translating into the qolsys. The "Takeover" module is a https://qolsys.com/iq-hardwire-powerg/ which adds the ability to have hardwired zones into the system. I think it really only has a tamper. The second is Resolution Products RE524X which has the ability to translate from one wireless sensor type into another. This shows up as a "translator". I believe it also only has a tamper. All of the translated sensors show up correctly as do the wired zones. I just get a ton of messages (see above) about unknown types for the translators themselves.

XaF commented 1 year ago

Any way you could trigger the tamper on the sensor to see if you get ZONE_ACTIVE messages?

XaF commented 1 year ago

Could you also please open a separate issue for the two sensor types? The TakeoverModule sensor type is not the same as the translator one.

efaden commented 1 year ago

2023-02-21 13:32:06.962577 DEBUG qolsys_panel: Data received (len: 320): {"event":"ZONE_EVENT","zone_event_type":"ZONE_UPDATE","zone":{"id":"9441A8","type":"Translator","name":"Translator","group":"translator","status":"Closed","state":"0","zone_id":13,"zone_physical_type":14,"zone_alarm_type":0,"zone_type":20,"partition_id":0},"version":1,"requestID":"81c7dfd7-b781-483e-818d-5aae2cff643a"}

2023-02-21 13:32:06.967262 DEBUG qolsys_panel: Unknown sensor in Qolsys event: {"event":"ZONE_EVENT","zone_event_type":"ZONE_UPDATE","zone":{"id":"9441A8","type":"Translator","name":"Translator","group":"translator","status":"Closed","state":"0","zone_id":13,"zone_physical_type":14,"zone_alarm_type":0,"zone_type":20,"partition_id":0},"version":1,"requestID":"81c7dfd7-b781-483e-818d-5aae2cff643a"}

2023-02-21 13:32:36.796625 DEBUG qolsys_panel: Data received (len: 320): {"event":"ZONE_EVENT","zone_event_type":"ZONE_UPDATE","zone":{"id":"9441A8","type":"Translator","name":"Translator","group":"translator","status":"Closed","state":"0","zone_id":13,"zone_physical_type":14,"zone_alarm_type":0,"zone_type":20,"partition_id":0},"version":1,"requestID":"33608ede-2ab6-4c3a-8143-092c434b4059"}

2023-02-21 13:32:17.526758 DEBUG qolsys_panel: Data received (len: 155): {"event":"ZONE_EVENT","zone_event_type":"ZONE_ACTIVE","version":1,"zone":{"status":"Open","zone_id":13},"requestID":"3819e86a-c11b-45f4-912c-ea175de198ba"}

efaden commented 1 year ago

Made a new one with the takeover module.

XaF commented 1 year ago

Thank you! So I guess the sensor itself does not have any open/close status, but does support tamper messages! I do not want to have different format for the sensors, so it probably will be a sensor that does not change status but has a tamper attribute that does.

That being said, I might want to think about adding extra security sensors for each sensor to represent the tamper, which would allow to decide for sensors which needs to be disabled by default (sensor itself, tamper sensor, or both). That'd add more sensors to handle in Home Assistant, but could trace a better portrait of what actually is happening. Opened #98 to think about this.

efaden commented 1 year ago

That's correct. Both of the ones I added don't really have any built in sensors. They have a tamper. The hardwire take over does have some functionally like pgm, bell, etc....

On Wed, Feb 22, 2023, 00:26 Raphaël Beamonte @.***> wrote:

Thank you! So I guess the sensor itself does not have any open/close status, but does support tamper messages! I do not want to have different format for the sensors, so it probably will be a sensor that does not change status but has a tamper attribute that does.

That being said, I might want to think about adding extra security sensors for each sensor to represent the tamper, which would allow to decide for sensors which needs to be disabled by default (sensor itself, tamper sensor, or both). That'd add more sensors to handle in Home Assistant, but could trace a better portrait of what actually is happening. Opened #98 https://github.com/XaF/qolsysgw/issues/98 to think about this.

— Reply to this email directly, view it on GitHub https://github.com/XaF/qolsysgw/issues/96#issuecomment-1439458118, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADAEABGOCMPF3Z55OP3ZML3WYWPPDANCNFSM6AAAAAAVDDARQ4 . You are receiving this because you authored the thread.Message ID: @.***>

Anto79-ops commented 1 year ago

thanks for looking into this...I also have a translator and this message is also in my logs. Following.

XaF / qolsysgw